Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Revert decorator refactors #17649

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Feb 21, 2019

This reverts the recent decorators refactors on beta to unblock users of ember-concurrency and other addons as we polish up the implementation to land in 3.10. The reverted commits are:

095cdd83d71dd614e934346242f2d6ee19c0ad39
287afaee33d069981bc49f0f9b8bf0c05dbb419f
687ec2c90ebb144d38b6954e333dc26104600d4f
b7c7eaf792545c2dcbc87b8ba7453d48f32f840f
0070773cf9c1cd1d885b8c9e3620e07d160a1246
53b84e24220861bb45987b0dfd2461b70c909fe8
1c72067eccef15c294c9d55d66e18241f4336a11

@jdaviderb
Copy link

great

bendemboski pushed a commit to bendemboski/ember-file-upload that referenced this pull request Feb 26, 2019
`ember-concurrency` does not work with the current Ember beta, and it is used by `ember-addon-docs`. Until something like machty/ember-concurrency#277 makes `ember-concurrency` work again, or emberjs/ember.js#17649 is released to the beta channel to remove the breaking change, we need to allow failures in beta :(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants